-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): Verify base image with cosign before building #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why the move of maximize build space? |
It's only something that's beneficial when we begin the build. By moving it, we can get everything else out of the way first. I.E., if we maximize build space and then verify the base image that then fails, we've wasted a fair bit of time and resources for nothing Will fix this PR momentarily |
Validates the integrity of the base image being built from via cosign before continuing to build. Ensures we only build with signed images
xynydev
approved these changes
Dec 31, 2023
elgabo86
referenced
this pull request
in elgabo86/gablue
Dec 31, 2023
feat(ci): Verify base image with cosign before building (#211)
noahdotpy
referenced
this pull request
in noahdotpy/myfedora
Jan 5, 2024
* feat(ci): Verify base image with cosign before building Validates the integrity of the base image being built from via cosign before continuing to build. Ensures we only build with signed images * fix(ci): Extract base image name from base image URL for verification
CheariX
pushed a commit
to CheariX/chearixblue
that referenced
this pull request
Jan 6, 2024
* feat(ci): Verify base image with cosign before building Validates the integrity of the base image being built from via cosign before continuing to build. Ensures we only build with signed images * fix(ci): Extract base image name from base image URL for verification
CheariX
pushed a commit
to CheariX/chearixblue
that referenced
this pull request
Jan 6, 2024
* feat(ci): Verify base image with cosign before building Validates the integrity of the base image being built from via cosign before continuing to build. Ensures we only build with signed images * fix(ci): Extract base image name from base image URL for verification
Craftidore
referenced
this pull request
in Craftidore/shale
Jan 27, 2024
* feat(ci): Verify base image with cosign before building Validates the integrity of the base image being built from via cosign before continuing to build. Ensures we only build with signed images * fix(ci): Extract base image name from base image URL for verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates the integrity of the base image being built from via cosign before continuing to build. Ensures we only build with signed images